Adding some comments, editing methods names

mods/clone/clone_manager.py

@@ -1,5 +1,5 @@
 from typing import Optional, TYPE_CHECKING
-from core.definition import MClone
+from mods.clone.schemas import MClone
 
 if TYPE_CHECKING:
     from mods.clone.mod_clone import Clone
@@ -16,33 +16,24 @@ class CloneManager:
         """Create new Clone object
 
         Args:
-            newCloneObject (CloneModel): New CloneModel object
+            new_clone_object (MClone): New Clone object
 
         Returns:
             bool: True if inserted
         """
-        result = False
-        exist = False
+        if new_clone_object is None:
+            self.Logs.debug('New Clone object must not be None')
+            return False
 
         for record in self.UID_CLONE_DB:
-            if record.nickname == new_clone_object.nickname:
+            if record.nickname == new_clone_object.nickname or record.uid == new_clone_object.uid:
                 # If the user exist then return False and do not go further
-                exist = True
-                self.Logs.warning(f'Nickname {record.nickname} already exist')
-                return result
-            if record.uid == new_clone_object.uid:
-                exist = True
-                self.Logs.warning(f'UID: {record.uid} already exist')
-                return result
+                self.Logs.debug(f'Nickname/UID {record.nickname}/{record.uid} already exist')
+                return False
 
-        if not exist:
-            self.UID_CLONE_DB.append(new_clone_object)
-            result = True
-
-        if not result:
-            self.Logs.critical(f'The Clone Object was not inserted {new_clone_object}')
-
-        return result
+        self.UID_CLONE_DB.append(new_clone_object)
+        self.Logs.debug(f'New Clone object created: {new_clone_object}')
+        return True
 
     def delete(self, uidornickname: str) -> bool:
         """Delete the Clone Object starting from the nickname or the UID

mods/clone/mod_clone.py

@@ -1,6 +1,4 @@
-import time, logging
-from typing import TYPE_CHECKING, Optional
-from faker import Faker
+from typing import TYPE_CHECKING, Optional, Any
 import mods.clone.utils as utils
 import mods.clone.threads as thds
 import mods.clone.schemas as schemas
@@ -8,40 +6,41 @@ from mods.clone.clone_manager import CloneManager
 
 if TYPE_CHECKING:
     from core.irc import Irc
+    from faker import Faker
 
-class Clone():
+class Clone:
 
-    def __init__(self, ircInstance: 'Irc') -> None:
+    def __init__(self, irc_instance: 'Irc') -> None:
 
         # Module name (Mandatory)
         self.module_name = 'mod_' + str(self.__class__.__name__).lower()
 
         # Add Irc Object to the module (Mandatory)
-        self.Irc = ircInstance
+        self.Irc = irc_instance
 
         # Add Irc Protocol Object to the module (Mandatory)
-        self.Protocol = ircInstance.Protocol
+        self.Protocol = irc_instance.Protocol
 
         # Add Global Configuration to the module (Mandatory)
-        self.Config = ircInstance.Config
+        self.Config = irc_instance.Config
 
         # Add Base object to the module (Mandatory)
-        self.Base = ircInstance.Base
+        self.Base = irc_instance.Base
 
         # Add logs object to the module (Mandatory)
-        self.Logs = ircInstance.Base.logs
+        self.Logs = irc_instance.Base.logs
 
         # Add User object to the module (Mandatory)
-        self.User = ircInstance.User
+        self.User = irc_instance.User
 
         # Add Channel object to the module (Mandatory)
-        self.Channel = ircInstance.Channel
+        self.Channel = irc_instance.Channel
         
         # Add global definitions
-        self.Definition = ircInstance.Loader.Definition
+        self.Definition = irc_instance.Loader.Definition
 
         # The Global Settings
-        self.Settings = ircInstance.Loader.Settings
+        self.Settings = irc_instance.Loader.Settings
 
         self.Schemas = schemas
 
@@ -88,8 +87,6 @@ class Clone():
     def __create_tables(self) -> None:
         """Methode qui va créer la base de donnée si elle n'existe pas.
            Une Session unique pour cette classe sera crée, qui sera utilisé dans cette classe / module
-        Args:
-            database_name (str): Nom de la base de données ( pas d'espace dans le nom )
 
         Returns:
             None: Aucun retour n'es attendu
@@ -136,15 +133,15 @@ class Clone():
 
         return None
 
-    def cmd(self, data:list):
+    def cmd(self, data:list) -> None:
         try:
             if not data or len(data) < 2:
-                return
+                return None
 
             cmd = data.copy() if isinstance(data, list) else list(data).copy()
             index, command = self.Irc.Protocol.get_ircd_protocol_poisition(cmd)
             if index == -1:
-                return
+                return None
 
             match command:
 
@@ -152,15 +149,16 @@ class Clone():
                     return self.Utils.handle_on_privmsg(self, cmd)
 
                 case 'QUIT':
-                    return
+                    return None
 
                 case _:
-                    return
+                    return None
 
         except Exception as err:
             self.Logs.error(f'General Error: {err}', exc_info=True)
+            return None
 
-    def hcmds(self, user: str, channel: any, cmd: list, fullcmd: list = []) -> None:
+    def hcmds(self, user: str, channel: Any, cmd: list, fullcmd: list = []) -> None:
 
         try:
 
@@ -310,7 +308,7 @@ class Clone():
                             try:
                                 # clone say clone_nickname #channel message
                                 clone_name = str(cmd[2])
-                                clone_channel = str(cmd[3]) if self.Channel.Is_Channel(str(cmd[3])) else None
+                                clone_channel = str(cmd[3]) if self.Channel.is_valid_channel(str(cmd[3])) else None
 
                                 final_message = ' '.join(cmd[4:])
 

mods/clone/threads.py

@@ -12,7 +12,12 @@ def thread_connect_clones(uplink: 'Clone',
                           ):
 
     for i in range(0, number_of_clones):
-        uplink.Utils.create_new_clone(uplink, uplink.Faker, group=group, auto_remote_ip=auto_remote_ip)
+        uplink.Utils.create_new_clone(
+            uplink=uplink,
+            faker_instance=uplink.Faker,
+            group=group,
+            auto_remote_ip=auto_remote_ip
+        )
 
     for clone in uplink.Clone.UID_CLONE_DB: