fix(oauth): provider username is ignored when signing up using OAuth (#511)

* 🐛 Bug Report: Provider username is ignored when signing up using OAuth Fixes #505 Signed-off-by: Marvin A. Ruder <signed@mruder.dev> * Implement fallback logic for username conflicts * Reprioritize claims for OIDC provider username Signed-off-by: Marvin A. Ruder <signed@mruder.dev> --------- Signed-off-by: Marvin A. Ruder <signed@mruder.dev>
2024-07-01 10:34:31 +02:00
parent 2dac38560b
commit 31366d961f
2 changed files with 7 additions and 7 deletions
--- a/backend/src/oauth/provider/genericOidc.provider.ts
+++ b/backend/src/oauth/provider/genericOidc.provider.ts
@@ -125,9 +125,9 @@ export abstract class GenericOidcProvider implements OAuthProvider<OidcToken> {

    const username = claim
      ? idTokenData[claim]
-      : idTokenData.name ||
-        idTokenData.nickname ||
-        idTokenData.preferred_username;
+      : idTokenData.preferred_username ||
+        idTokenData.name ||
+        idTokenData.nickname;

    if (!username) {
      this.logger.error(